• Arnaldo Carvalho de Melo's avatar
    perf top: Allow disabling the overwrite mode · 4e303fbe
    Arnaldo Carvalho de Melo authored
    In ebebbf08 ("perf top: Switch default mode to overwrite mode") we
    forgot to leave a way to disable that new default, add a --overwrite
    option that can be disabled using --no-overwrite, since the code already
    in such a way that we can readily disable this mode.
    
    This is useful when investigating bugs with this mode like the recent
    report from David Miller where lots of unknown symbols appear due to
    disabling the events while processing them which disables all record
    types, not just PERF_RECORD_SAMPLE, which makes it impossible to resolve
    maps when we lose PERF_RECORD_MMAP records.
    
    This can be easily seen while building a kernel, when there are lots of
    short lived processes.
    Reported-by: default avatarDavid Miller <davem@davemloft.net>
    Acked-by: default avatarKan Liang <kan.liang@intel.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jin Yao <yao.jin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Wang Nan <wangnan0@huawei.com>
    Fixes: ebebbf08 ("perf top: Switch default mode to overwrite mode")
    Link: https://lkml.kernel.org/n/tip-oqgsz2bq4kgrnnajrafcdhie@git.kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    4e303fbe
perf-top.txt 8.17 KB