• Kuninori Morimoto's avatar
    ASoC: soc-pcm: unpack dpcm_set_fe_runtime() · 4fe28461
    Kuninori Morimoto authored
    dpcm_fe_dai_startup() (= A) calls dpcm_set_fe_runtime() (= B) to setup
    DPCM runtime. From *naming point of view*, it sounds like setup function
    for FE.
    
    (A)	static int dpcm_fe_dai_startup(...)
    	{
    		...
    (B)		dpcm_set_fe_runtime(...);
    		...
    	}
    
    But in dpcm_set_fe_runtime() (= B),
    It  setups FE by dpcm_runtime_setup_fe() (= X),
    and setups BE by dpcm_runtime_merge_xxx() (= Y).
    
    (B)	static void dpcm_set_fe_runtime(...)
    	{
    		...
    (X)		dpcm_runtime_setup_fe(...);
    
     ^		dpcm_runtime_setup_be_format(...);
    (Y)		dpcm_runtime_setup_be_chan(...);
     v		dpcm_runtime_setup_be_rate(...);
    	}
    
    These means that the function which is called as xxx_fe_xxx()
    is setups both FE and BE. This is confusable and can be hot bed for bug.
    
    Now dpcm_set_fe_runtime() (= B) is simple enough and confusable naming,
    let's unpack it at dpcm_fe_dai_startup().
    Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Link: https://lore.kernel.org/r/87mtvxvsgn.wl-kuninori.morimoto.gx@renesas.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    4fe28461
soc-pcm.c 77.5 KB