• Xin Long's avatar
    net: sched: ensure opts_len <= IP_TUNNEL_OPTS_MAX in act_tunnel_key · 4f0e97d0
    Xin Long authored
    info->options_len is 'u8' type, and when opts_len with a value >
    IP_TUNNEL_OPTS_MAX, 'info->options_len = opts_len' will cast int
    to u8 and set a wrong value to info->options_len.
    
    Kernel crashed in my test when doing:
    
      # opts="0102:80:00800022"
      # for i in {1..99}; do opts="$opts,0102:80:00800022"; done
      # ip link add name geneve0 type geneve dstport 0 external
      # tc qdisc add dev eth0 ingress
      # tc filter add dev eth0 protocol ip parent ffff: \
           flower indev eth0 ip_proto udp action tunnel_key \
           set src_ip 10.0.99.192 dst_ip 10.0.99.193 \
           dst_port 6081 id 11 geneve_opts $opts \
           action mirred egress redirect dev geneve0
    
    So we should do the similar check as cls_flower does, return error
    when opts_len > IP_TUNNEL_OPTS_MAX in tunnel_key_copy_opts().
    
    Fixes: 0ed5269f ("net/sched: add tunnel option support to act_tunnel_key")
    Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
    Reviewed-by: default avatarSimon Horman <simon.horman@netronome.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    4f0e97d0
act_tunnel_key.c 16.5 KB