• Thomas Gleixner's avatar
    powerpc/4xx: Remove MSI support which never worked · 4f1d038b
    Thomas Gleixner authored
    This code is broken since day one. ppc4xx_setup_msi_irqs() has the
    following gems:
    
     1) The handling of the result of msi_bitmap_alloc_hwirqs() is completely
        broken:
        
        When the result is greater than or equal 0 (bitmap allocation
        successful) then the loop terminates and the function returns 0
        (success) despite not having installed an interrupt.
    
        When the result is less than 0 (bitmap allocation fails), it prints an
        error message and continues to "work" with that error code which would
        eventually end up in the MSI message data.
    
     2) On every invocation the file global pp4xx_msi::msi_virqs bitmap is
        allocated thereby leaking the previous one.
    
    IOW, this has never worked and for more than 10 years nobody cared. Remove
    the gunk.
    
    Fixes: 3fb79338 ("powerpc/4xx: Adding PCIe MSI support")
    Fixes: 247540b0 ("powerpc/44x: Fix PCI MSI support for Maui APM821xx SoC and Bluestone board")
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
    Link: https://lore.kernel.org/r/20211206210223.872249537@linutronix.de
    4f1d038b
Kconfig 609 Bytes