• Lai Jiangshan's avatar
    KVM: X86: Handle implicit supervisor access with SMAP · 4f4aa80e
    Lai Jiangshan authored
    There are two kinds of implicit supervisor access
    	implicit supervisor access when CPL = 3
    	implicit supervisor access when CPL < 3
    
    Current permission_fault() handles only the first kind for SMAP.
    
    But if the access is implicit when SMAP is on, data may not be read
    nor write from any user-mode address regardless the current CPL.
    
    So the second kind should be also supported.
    
    The first kind can be detect via CPL and access mode: if it is
    supervisor access and CPL = 3, it must be implicit supervisor access.
    
    But it is not possible to detect the second kind without extra
    information, so this patch adds an artificial PFERR_EXPLICIT_ACCESS
    into @access. This extra information also works for the first kind, so
    the logic is changed to use this information for both cases.
    
    The value of PFERR_EXPLICIT_ACCESS is deliberately chosen to be bit 48
    which is in the most significant 16 bits of u64 and less likely to be
    forced to change due to future hardware uses it.
    
    This patch removes the call to ->get_cpl() for access mode is determined
    by @access.  Not only does it reduce a function call, but also remove
    confusions when the permission is checked for nested TDP.  The nested
    TDP shouldn't have SMAP checking nor even the L2's CPL have any bearing
    on it.  The original code works just because it is always user walk for
    NPT and SMAP fault is not set for EPT in update_permission_bitmask.
    Signed-off-by: default avatarLai Jiangshan <jiangshan.ljs@antgroup.com>
    Message-Id: <20220311070346.45023-5-jiangshanlai@gmail.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    4f4aa80e
mmu.h 9.38 KB