• Alexander Aring's avatar
    fs: dlm: remove socket shutdown handling · 4f567acb
    Alexander Aring authored
    Since commit 489d8e55 ("fs: dlm: add reliable connection if
    reconnect") we have functionality like TCP offers for half-closed
    sockets on dlm application protocol layer. This feature is required
    because the cluster manager events about leaving resource memberships
    can be locally already occurred but other cluster nodes having a pending
    leaving membership over the cluster manager protocol happening. In this
    time the local dlm node already shutdown it's connection and don't
    transmit anymore any new dlm messages, but however it still needs to be
    able to accept dlm messages because the pending leave membership request
    of the cluster manager protocol which the dlm kernel implementation has
    no control about it.
    
    We have this functionality on the application for two reasons, the main
    reason is that SCTP does not support such functionality on socket
    layer. But we can do it inside application layer.
    
    Another small issue is that this feature is broken in the TCP world
    because some NAT devices does not implement such functionality
    correctly. This is the same reason why the reliable connection session
    layer in DLM exists. We give up on middle devices in the networking
    which sends e.g. TCP resets out. In DLM we cannot have any message
    dropping and we ensure it over a session layer that it can't happen.
    
    Back to the half-closed grace shutdown handling. It's not necessary
    anymore to do it on socket layer (which is only support for TCP sockets)
    because we do it on application layer. This patch removes this handling,
    if there are still issues then we have a problem on the application
    layer for such handling.
    Signed-off-by: default avatarAlexander Aring <aahringo@redhat.com>
    Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
    4f567acb
lowcomms.c 45.3 KB