• Julia Lawall's avatar
    [CPUFREQ] arch/x86/kernel/cpu/cpufreq: Fix unsigned return type · b2a33c17
    Julia Lawall authored
    In each case, the function has an unsigned return type, but returns a
    negative constant to indicate an error condition.  Each function is only
    called once.  For nforce2_detect_chipset, the result is only compared to 0,
    and for longrun_determine_freqs, the result is stored in a variable of type
    (signed) int.  Thus, for both functions, unsigned can be dropped from the
    return type.
    
    A sematic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @exists@
    identifier f;
    constant C;
    @@
    
     unsigned f(...)
     { <+...
    *  return -C;
     ...+> }
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Signed-off-by: default avatarDave Jones <davej@redhat.com>
    b2a33c17
cpufreq-nforce2.c 9.3 KB