• Lars Ellenberg's avatar
    drbd: fix race between drbdadm invalidate/verify and finishing resync · a574daf5
    Lars Ellenberg authored
    When a resync or online verify is finished or aborted,
    drbd does a bulk write-out of changed bitmap pages.
    
    If *in that very moment* a new verify or resync is triggered,
    this can race:
     ASSERT( !test_bit(BITMAP_IO, &mdev->flags) ) in drbd_main.c
     FIXME going to queue 'set_n_write from StartingSync' but 'write from resync_finished' still pending?
    and similar.
    
    This can be observed with e.g. tight invalidate loops in test scripts,
    and probably has no real-life implication.
    
    Still, that race can be solved by first quiescen the device,
    before starting a new resync or verify.
    Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
    Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
    a574daf5
drbd_nl.c 73.8 KB