• Daniel Lezcano's avatar
    thermal/drivers/bcm2835: Remove buggy call to thermal_of_zone_unregister · 8454c8c0
    Daniel Lezcano authored
    The driver is using the devm_thermal_of_zone_device_register().
    
    In the error path of the function calling
    devm_thermal_of_zone_device_register(), the function
    devm_thermal_of_zone_unregister() should be called instead of
    thermal_of_zone_unregister(), otherwise this one will be called twice
    when the device is freed.
    
    The same happens for the remove function where the devm_ guarantee the
    thermal_of_zone_unregister() will be called, so adding this call in
    the remove function will lead to a double free also.
    
    Use devm_ variant in the error path of the probe function.
    
    Remove thermal_of_zone_unregister() in the remove function.
    
    Cc: Florian Fainelli <f.fainelli@gmail.com>
    Cc: Ray Jui <rjui@broadcom.com>
    Cc: Scott Branden <sbranden@broadcom.com>
    Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
    Link: https://lore.kernel.org/r/20230404075138.2914680-1-daniel.lezcano@linaro.org
    8454c8c0
bcm2835_thermal.c 7.67 KB