• D. Wythe's avatar
    net/smc: fix dangling sock under state SMC_APPFINCLOSEWAIT · 5211c972
    D. Wythe authored
    Considering scenario:
    
    				smc_cdc_rx_handler
    __smc_release
    				sock_set_flag
    smc_close_active()
    sock_set_flag
    
    __set_bit(DEAD)			__set_bit(DONE)
    
    Dues to __set_bit is not atomic, the DEAD or DONE might be lost.
    if the DEAD flag lost, the state SMC_CLOSED  will be never be reached
    in smc_close_passive_work:
    
    if (sock_flag(sk, SOCK_DEAD) &&
    	smc_close_sent_any_close(conn)) {
    	sk->sk_state = SMC_CLOSED;
    } else {
    	/* just shutdown, but not yet closed locally */
    	sk->sk_state = SMC_APPFINCLOSEWAIT;
    }
    
    Replace sock_set_flags or __set_bit to set_bit will fix this problem.
    Since set_bit is atomic.
    
    Fixes: b38d7324 ("smc: socket closing and linkgroup cleanup")
    Signed-off-by: default avatarD. Wythe <alibuda@linux.alibaba.com>
    Reviewed-by: default avatarDust Li <dust.li@linux.alibaba.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    5211c972
smc_close.c 12.7 KB