• Gustavo A. R. Silva's avatar
    nouveau/gsp: replace zero-length array with flex-array member and use __counted_by · 52fdb99c
    Gustavo A. R. Silva authored
    Fake flexible arrays (zero-length and one-element arrays) are deprecated,
    and should be replaced by flexible-array members. So, replace
    zero-length array with a flexible-array member in `struct
    PACKED_REGISTRY_TABLE`.
    
    Also annotate array `entries` with `__counted_by()` to prepare for the
    coming implementation by GCC and Clang of the `__counted_by` attribute.
    Flexible array members annotated with `__counted_by` can have their
    accesses bounds-checked at run-time via `CONFIG_UBSAN_BOUNDS` (for array
    indexing) and `CONFIG_FORTIFY_SOURCE` (for strcpy/memcpy-family functions).
    
    This fixes multiple -Warray-bounds warnings:
    drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1069:29: warning: array subscript 0 is outside array bounds of 'PACKED_REGISTRY_ENTRY[0]' [-Warray-bounds=]
    drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1070:29: warning: array subscript 0 is outside array bounds of 'PACKED_REGISTRY_ENTRY[0]' [-Warray-bounds=]
    drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1071:29: warning: array subscript 0 is outside array bounds of 'PACKED_REGISTRY_ENTRY[0]' [-Warray-bounds=]
    drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1072:29: warning: array subscript 0 is outside array bounds of 'PACKED_REGISTRY_ENTRY[0]' [-Warray-bounds=]
    
    While there, also make use of the struct_size() helper, and address
    checkpatch.pl warning:
    WARNING: please, no spaces at the start of a line
    
    This results in no differences in binary output.
    Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
    Reviewed-by: default avatarKees Cook <keescook@chromium.org>
    Signed-off-by: default avatarDanilo Krummrich <dakr@redhat.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/ZVZbX7C5suLMiBf+@work
    52fdb99c
r535.c 57.1 KB