• Gustavo Sousa's avatar
    drm/i915/cdclk: Add and use mdclk_source_is_cdclk_pll() · 5372a54d
    Gustavo Sousa authored
    Currently, only Xe2LPD uses CDCLK PLL as the source of MDCLK and
    previous display IPs use the CD2XCLK. There will be changes in code
    paths common to those platforms that will rely on which source is being
    used. As such, let's make that information explicit with the addition of
    the predicate function mdclk_source_is_cdclk_pll().
    
    Arguably, an enum could be created, but using a boolean should suffice
    here, since we there are only two possible sources and the logic that
    will rely on it will be very localized.
    
    In order to get the code into a more consistent state, let's also take
    this opportunity to hook the selection of CDCLK_CTL's "MDCLK Source
    Select" to that new function. Even though currently only
    MDCLK_SOURCE_SEL_CDCLK_PLL will be returned, having this extra logic is
    arguably better than keeping stuff untied and prone to bugs.
    
    v2:
      - Extract mdclk_source_is_cdclk_pll() out of xe2lpd_mdclk_source_sel()
        to make latter only about the register's field.
    
    Bspec: 69090, 68861
    Cc: Matt Roper <matthew.d.roper@intel.com>
    Signed-off-by: default avatarGustavo Sousa <gustavo.sousa@intel.com>
    Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20240312163639.172321-3-gustavo.sousa@intel.comSigned-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
    5372a54d
i915_reg.h 272 KB