• Daniel Vetter's avatar
    drm/komeda: Annotate dma-fence critical section in commit path · 53fc08c2
    Daniel Vetter authored
    Like the helpers, nothing special. Well except not, because we the
    critical section extends until after hw_done(), since that's the last
    thing which could hold up a subsequent atomic commit. That means the
    wait_for_flip_done is included, but that's not a problem, we're
    allowed to call dma_fence_wait() from signalling critical sections.
    Even on our own fence (which this does), it's just a bit confusing.
    But in a way those last 2 function calls are already part of the fence
    signalling critical section for the next atomic commit.
    
    Reading this I'm wondering why komeda waits for flip_done() before
    calling hw_done(), which is a bit backwards (but hey hw can be
    special). Might be good to throw a comment in there that explains why,
    because the original commit that added this just doesn't.
    
    v2: Small rebase
    
    Reviewed-by: James Qian Wang <james.qian.wang@arm.com> (v1)
    Cc: "James (Qian) Wang" <james.qian.wang@arm.com>
    Cc: Liviu Dudau <liviu.dudau@arm.com>
    Cc: Mihail Atanassov <mihail.atanassov@arm.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210121152959.1725404-5-daniel.vetter@ffwll.ch
    53fc08c2
komeda_kms.c 8.77 KB