• Jacob Keller's avatar
    fm10k: convert NON_Q_VECTORS(hw) into NON_Q_VECTORS · a3ffeaf7
    Jacob Keller authored
    The driver currently uses a macro to decide whether we should use
    NON_Q_VECTORS_PF or NON_Q_VECTORS_VF.
    
    However, we also define NON_Q_VECTORS_VF to the same value as
    NON_Q_VECTORS_PF. This means that the macro NON_Q_VECTORS(hw) will
    always return the same value.
    
    Let's just remove this macro, and replace it directly with an enum value
    on the enum non_q_vectors.
    
    This was detected by cppcheck and fixes the following warnings when
    building with BUILD=KERNEL
    
    [fm10k_ethtool.c:1123]: (style) Same value in both branches of ternary
    operator.
    
    [fm10k_ethtool.c:1142]: (style) Same value in both branches of ternary
    operator.
    
    [fm10k_main.c:1826]: (style) Same value in both branches of ternary
    operator.
    
    [fm10k_main.c:1849]: (style) Same value in both branches of ternary
    operator.
    
    [fm10k_main.c:1858]: (style) Same value in both branches of ternary
    operator.
    
    [fm10k_pci.c:901]: (style) Same value in both branches of ternary
    operator.
    
    [fm10k_pci.c:1040]: (style) Same value in both branches of ternary
    operator.
    
    [fm10k_pci.c:1726]: (style) Same value in both branches of ternary
    operator.
    
    [fm10k_pci.c:1763]: (style) Same value in both branches of ternary
    operator.
    Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
    Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
    Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
    a3ffeaf7
fm10k_ethtool.c 30.9 KB