• Hoang Le's avatar
    tipc: fix skb truesize/datasize ratio control · 55b3280d
    Hoang Le authored
    In commit d618d09a ("tipc: enforce valid ratio between skb truesize
    and contents") we introduced a test for ensuring that the condition
    truesize/datasize <= 4 is true for a received buffer. Unfortunately this
    test has two problems.
    
    - Because of the integer arithmetics the test
      if (skb->truesize / buf_roundup_len(skb) > 4) will miss all
      ratios [4 < ratio < 5], which was not the intention.
    - The buffer returned by skb_copy() inherits skb->truesize of the
      original buffer, which doesn't help the situation at all.
    
    In this commit, we change the ratio condition and replace skb_copy()
    with a call to skb_copy_expand() to finally get this right.
    Acked-by: default avatarJon Maloy <jon.maloy@ericsson.com>
    Signed-off-by: default avatarJon Maloy <jon.maloy@ericsson.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    55b3280d
msg.c 19.1 KB