• John Harrison's avatar
    drm/i915/guc: Fix capture size warning and bump the size · 56c7f0e2
    John Harrison authored
    There was a size check to warn if the GuC error state capture buffer
    allocation would be too small to fit a reasonable amount of capture
    data for the current platform. Unfortunately, the test was done too
    early in the boot sequence and was actually testing 'if(-ENODEV >
    size)'.
    
    Move the check to be later. The check is only used to print a warning
    message, so it doesn't really matter how early or late it is done.
    Note that it is not possible to dynamically size the buffer because
    the allocation needs to be done before the engine information is
    available (at least, it would be in the intended two-phase GuC init
    process).
    
    Now that the check works, it is reporting size too small for newer
    platforms. The check includes a 3x oversample multiplier to allow for
    multiple error captures to be bufferd by GuC before i915 has a chance
    to read them out. This is less important than simply being big enough
    to fit the first capture.
    
    So a) bump the default size to be large enough for one capture minimum
    and b) make the warning only if one capture won't fit, instead use a
    notice for the 3x size.
    
    Note that the size estimate is a worst case scenario. Actual captures
    will likely be smaller.
    
    Lastly, use drm_warn istead of DRM_WARN as the former provides more
    infmration and the latter is deprecated.
    Signed-off-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
    Reviewed-by: default avatarAlan Previn <alan.previn.teres.alexis@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220728022028.2190627-3-John.C.Harrison@Intel.com
    56c7f0e2
intel_guc_capture.h 1.12 KB