• Stephane Eranian's avatar
    perf tools: Fix piped mode read code · 444d2866
    Stephane Eranian authored
    In __perf_session__process_pipe_events(), there was a risk we would read
    more than what a union perf_event struct can hold. this could happen in
    case, perf is reading a file which contains new record types it does not
    know about and which are larger than anything it knows about.
    
    In general, perf is supposed to skip records it does not understand, but
    in pipe mode, those have to be read and ignored.  The fixed size header
    contains the size of the record, but that size may be larger than union
    perf_event, yet it was used as the backing to the read in:
    
      union perf_event event;
      void *p;
    
      size = event->header.size;
    
      p = &event;
      p += sizeof(struct perf_event_header);
      if (size - sizeof(struct perf_event_header)) {
        err = readn(self->fd, p, size - sizeof(struct perf_event_header));
    
    We fix this by allocating a buffer based on the size reported in the
    header. We reuse the buffer as much as we can. We realloc in case it
    becomes too small. In the  common case, the performance impact is
    negligible.
    Signed-off-by: default avatarStephane Eranian <eranian@google.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/1337081295-10303-3-git-send-email-eranian@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    444d2866
session.c 39.8 KB