• Alex Elder's avatar
    libceph: account for alignment in pages cursor · 56fc5659
    Alex Elder authored
    When a cursor for a page array data message is initialized it needs
    to determine the initial value for cursor->last_piece.  Currently it
    just checks if length is less than a page, but that's not correct.
    The data in the first page in the array will be offset by a page
    offset based on the alignment recorded for the data.  (All pages
    thereafter will be aligned at the base of the page, so there's
    no need to account for this except for the first page.)
    
    Because this was wrong, there was a case where the length of a piece
    would be calculated as all of the residual bytes in the message and
    that plus the page offset could exceed the length of a page.
    
    So fix this case.  Make sure the sum won't wrap.
    
    This resolves a third issue described in:
        http://tracker.ceph.com/issues/4598Signed-off-by: default avatarAlex Elder <elder@inktank.com>
    Reviewed-by: default avatarSage Weil <sage@inktank.com>
    56fc5659
messenger.c 79.4 KB