• Tyler Hicks's avatar
    eCryptfs: file->private_data is always valid · 2000f5be
    Tyler Hicks authored
    When accessing the lower_file pointer located in private_data of
    eCryptfs files, there is no need to check to see if the private_data
    pointer has been initialized to a non-NULL value. The file->private_data
    and file->private_data->lower_file pointers are always initialized to
    non-NULL values in ecryptfs_open().
    
    This change quiets a Smatch warning:
    
      CHECK   /var/scm/kernel/linux/fs/ecryptfs/file.c
    fs/ecryptfs/file.c:321 ecryptfs_unlocked_ioctl() error: potential NULL dereference 'lower_file'.
    fs/ecryptfs/file.c:335 ecryptfs_compat_ioctl() error: potential NULL dereference 'lower_file'.
    Signed-off-by: default avatarTyler Hicks <tyhicks@canonical.com>
    Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: default avatarGeyslan G. Bem <geyslan@gmail.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    2000f5be
file.c 10.3 KB