• Tejun Heo's avatar
    sched/core: Allow kthreads to fall back to online && !active cpus · feb245e3
    Tejun Heo authored
    During CPU hotplug, CPU_ONLINE callbacks are run while the CPU is
    online but not active.  A CPU_ONLINE callback may create or bind a
    kthread so that its cpus_allowed mask only allows the CPU which is
    being brought online.  The kthread may start executing before the CPU
    is made active and can end up in select_fallback_rq().
    
    In such cases, the expected behavior is selecting the CPU which is
    coming online; however, because select_fallback_rq() only chooses from
    active CPUs, it determines that the task doesn't have any viable CPU
    in its allowed mask and ends up overriding it to cpu_possible_mask.
    
    CPU_ONLINE callbacks should be able to put kthreads on the CPU which
    is coming online.  Update select_fallback_rq() so that it follows
    cpu_online() rather than cpu_active() for kthreads.
    Reported-by: default avatarGautham R Shenoy <ego@linux.vnet.ibm.com>
    Tested-by: default avatarGautham R. Shenoy <ego@linux.vnet.ibm.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
    Cc: Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: kernel-team@fb.com
    Cc: linuxppc-dev@lists.ozlabs.org
    Link: http://lkml.kernel.org/r/20160616193504.GB3262@mtj.duckdns.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    feb245e3
core.c 211 KB