• Yinghai Lu's avatar
    irq: only update affinity if ->set_affinity() is sucessfull · 57b150cc
    Yinghai Lu authored
    irq_set_affinity() and move_masked_irq() try to assign affinity
    before calling chip set_affinity(). Some archs are assigning it
    in ->set_affinity() again.
    
    We do something like:
    
     cpumask_cpy(desc->affinity, mask);
     desc->chip->set_affinity(mask);
    
    But in the failure path, affinity should not be touched - otherwise
    we'll end up with a different affinity mask despite the failure to
    migrate the IRQ.
    
    So try to update the afffinity only if set_affinity returns with 0.
    Also call irq_set_thread_affinity accordingly.
    
    v2: update after "irq, x86: Remove IRQ_DISABLED check in process context IRQ move"
    v3: according to Ingo, change set_affinity() in irq_chip should return int.
    v4: update comments by removing moving irq_desc code.
    
    [ Impact: fix /proc/irq/*/smp_affinity setting corner case bug ]
    Signed-off-by: default avatarYinghai Lu <yinghai@kernel.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Suresh Siddha <suresh.b.siddha@intel.com>
    Cc: "Eric W. Biederman" <ebiederm@xmission.com>
    Cc: Rusty Russell <rusty@rustcorp.com.au>
    LKML-Reference: <49F65509.60307@kernel.org>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    57b150cc
internals.h 2.57 KB