• Stephane Eranian's avatar
    perf record: Prevent override of attr->sample_period for libpfm4 events · ae5dcc8a
    Stephane Eranian authored
    Before:
    
      $ perf record -c 10000 --pfm-events=cycles:period=77777
    
    Would yield a cycles event with period=10000, instead of 77777.
    
    the event string and perf record initializing the event.
    This was due to an ordering issue between libpfm4 parsing
    
    events with attr->sample_period != 0 by the time
    intent of the author.
    perf_evsel__config() is invoked. This seems to have been the
    This patch fixes the problem by preventing override for
    Signed-off-by: default avatarStephane Eranian <eranian@google.com>
    Reviewed-by: default avatarIan Rogers <irogers@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Alexei Starovoitov <ast@kernel.org>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Andrii Nakryiko <andriin@fb.com>
    Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
    Cc: Daniel Borkmann <daniel@iogearbox.net>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: John Fastabend <john.fastabend@gmail.com>
    Cc: KP Singh <kpsingh@chromium.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Martin KaFai Lau <kafai@fb.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Song Liu <songliubraving@fb.com>
    Cc: Yonghong Song <yhs@fb.com>
    Link: http://lore.kernel.org/lkml/20200912025655.1337192-3-irogers@google.comSigned-off-by: default avatarIan Rogers <irogers@google.com>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    ae5dcc8a
evsel.c 65.7 KB