• Ard Biesheuvel's avatar
    arm64: fix rodata=full again · 2081b3bd
    Ard Biesheuvel authored
    Commit 2e8cff0a ("arm64: fix rodata=full") addressed a couple of
    issues with the rodata= kernel command line option, which is not a
    simple boolean on arm64, and inadvertently got broken due to changes in
    the generic bool handling.
    
    Unfortunately, the resulting code never clears the rodata_full boolean
    variable if it defaults to true and rodata=on or rodata=off is passed,
    as the generic code is not aware of the existence of this variable.
    
    Given the way this code is plumbed together, clearing rodata_full when
    returning false from arch_parse_debug_rodata() may result in
    inconsistencies if the generic code decides that it cannot parse the
    right hand side, so the best way to deal with this is to only take
    rodata_full in account if rodata_enabled is also true.
    
    Fixes: 2e8cff0a ("arm64: fix rodata=full")
    Cc: <stable@vger.kernel.org> # 6.0.x
    Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
    Acked-by: default avatarWill Deacon <will@kernel.org>
    Link: https://lore.kernel.org/r/20221103170015.4124426-1-ardb@kernel.orgSigned-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    2081b3bd
pageattr.c 6.13 KB