• Dan Carpenter's avatar
    xfrm6: remove unneeded NULL check in __xfrm6_output() · 5b11b2e4
    Dan Carpenter authored
    We don't check for NULL consistently in __xfrm6_output().  If "x" were
    NULL here it would lead to an OOPs later.  I asked Steffen Klassert
    about this and he suggested that we remove the NULL check.
    
    On 10/29/11, Steffen Klassert <steffen.klassert@secunet.com> wrote:
    >> net/ipv6/xfrm6_output.c
    >>    148
    >>    149		if ((x && x->props.mode == XFRM_MODE_TUNNEL) &&
    >>                           ^
    >
    > x can't be null here. It would be a bug if __xfrm6_output() is called
    > without a xfrm_state attached to the skb. I think we can just remove
    > this null check.
    
    Cc: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    5b11b2e4
xfrm6_output.c 3.55 KB