• Julia Lawall's avatar
    drivers/usb/chipidea/core.c: adjust duplicate test · 5c6e9bf0
    Julia Lawall authored
    Delete successive tests to the same location.  In this case res has already
    been tested for being NULL, and calling devm_request_and_ioremap will not
    make it NULL.  On the other hand, devm_request_and_ioremap can return NULL
    on failure.
    
    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @s exists@
    local idexpression y;
    expression x,e;
    @@
    
    *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
     { ... when forall
       return ...; }
    ... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
        when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
    *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
     { ... when forall
       return ...; }
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    5c6e9bf0
core.c 12.5 KB