• Hugh Dickins's avatar
    mm: fix kernel BUG at mm/rmap.c:1017! · 5dbe0af4
    Hugh Dickins authored
    I've hit the "address >= vma->vm_end" check in do_page_add_anon_rmap()
    just once.  The stack showed khugepaged allocation trying to compact
    pages: the call to page_add_anon_rmap() coming from remove_migration_pte().
    
    That path holds anon_vma lock, but does not hold mmap_sem: it can
    therefore race with a split_vma(), and in commit 5f70b962 "mmap:
    avoid unnecessary anon_vma lock" we just took away the anon_vma lock
    protection when adjusting vma->vm_end.
    
    I don't think that particular BUG_ON ever caught anything interesting,
    so better replace it by a comment, than reinstate the anon_vma locking.
    Signed-off-by: default avatarHugh Dickins <hughd@google.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    5dbe0af4
rmap.c 48.5 KB