• Florian Westphal's avatar
    mptcp: handle mptcp listener destruction via rcu · 5e20087d
    Florian Westphal authored
    Following splat can occur during self test:
    
     BUG: KASAN: use-after-free in subflow_data_ready+0x156/0x160
     Read of size 8 at addr ffff888100c35c28 by task mptcp_connect/4808
    
      subflow_data_ready+0x156/0x160
      tcp_child_process+0x6a3/0xb30
      tcp_v4_rcv+0x2231/0x3730
      ip_protocol_deliver_rcu+0x5c/0x860
      ip_local_deliver_finish+0x220/0x360
      ip_local_deliver+0x1c8/0x4e0
      ip_rcv_finish+0x1da/0x2f0
      ip_rcv+0xd0/0x3c0
      __netif_receive_skb_one_core+0xf5/0x160
      __netif_receive_skb+0x27/0x1c0
      process_backlog+0x21e/0x780
      net_rx_action+0x35f/0xe90
      do_softirq+0x4c/0x50
      [..]
    
    This occurs when accessing subflow_ctx->conn.
    
    Problem is that tcp_child_process() calls listen sockets'
    sk_data_ready() notification, but it doesn't hold the listener
    lock.  Another cpu calling close() on the listener will then cause
    transition of refcount to 0.
    
    Fixes: 58b09919 ("mptcp: create msk early")
    Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
    Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    5e20087d
protocol.c 47.9 KB