• Manikanta Pubbisetty's avatar
    wifi: ath11k: Fix hardware restart failure due to twt debugfs failure · 607c467e
    Manikanta Pubbisetty authored
    Currently, creation of debugfs entries for TWT is failing during
    hardware restart because of the residual TWT files which were
    created during add_interface(). Since, struct arvif{} is memset
    to zero upon add_interface() invocation, when the hardware restart
    is triggered, arvif is memset to 0 and TWT files are attempted to
    create again which will fail because of the residual TWT files
    already in place, this leads to hardware restart failure.
    
    Also, it is not a good idea to return error from add_interface()
    because of debugfs file creation failures. Moreover, debugfs
    framework can very well handle the errors in it's create file &
    remove file APIs and the errors returned by these APIs are not
    checked in most usecases.
    
    Fix the HW restart failure by ignoring the errors returned from
    the debugfs APIs.
    
    Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
    
    Fixes: fe98a613 ("ath11k: add debugfs for TWT debug calls")
    Signed-off-by: default avatarManikanta Pubbisetty <quic_mpubbise@quicinc.com>
    Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
    Link: https://lore.kernel.org/r/20220720135150.22193-3-quic_mpubbise@quicinc.com
    607c467e
mac.c 240 KB