• Ben Hutchings's avatar
    3c59x: Remove incorrect locking; correct documented lock hierarchy · 24cd804d
    Ben Hutchings authored
    vortex_ioctl() was grabbing vortex_private::lock around its call to
    generic_mii_ioctl().  This is no longer necessary since there are more
    specific locks which the mdio_{read,write}() functions will obtain.
    Worse, those functions do not save and restore IRQ flags when locking
    the MII state, so interrupts will be enabled when generic_mii_ioctl()
    returns.
    
    Since there is currently no need for any function to call
    mdio_{read,write}() while holding another spinlock, do not change them
    to save and restore IRQ flags but remove the specification of ordering
    between vortex_private::lock and vortex_private::mii_lock.
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    24cd804d
3c59x.c 102 KB