• Chao Yu's avatar
    f2fs: fix to avoid touching checkpointed data in get_victim() · 61461fc9
    Chao Yu authored
    In CP disabling mode, there are two issues when using LFS or SSR | AT_SSR
    mode to select victim:
    
    1. LFS is set to find source section during GC, the victim should have
    no checkpointed data, since after GC, section could not be set free for
    reuse.
    
    Previously, we only check valid chpt blocks in current segment rather
    than section, fix it.
    
    2. SSR | AT_SSR are set to find target segment for writes which can be
    fully filled by checkpointed and newly written blocks, we should never
    select such segment, otherwise it can cause panic or data corruption
    during allocation, potential case is described as below:
    
     a) target segment has 'n' (n < 512) ckpt valid blocks
     b) GC migrates 'n' valid blocks to other segment (segment is still
        in dirty list)
     c) GC migrates '512 - n' blocks to target segment (segment has 'n'
        cp_vblocks and '512 - n' vblocks)
     d) If GC selects target segment via {AT,}SSR allocator, however there
        is no free space in targe segment.
    
    Fixes: 4354994f ("f2fs: checkpoint disabling")
    Fixes: 093749e2 ("f2fs: support age threshold based garbage collection")
    Signed-off-by: default avatarChao Yu <yuchao0@huawei.com>
    Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
    61461fc9
f2fs.h 135 KB