• Andi Kleen's avatar
    perf annotate: Inform the user about objdump failures in --stdio · 62ec9b3f
    Andi Kleen authored
    When the browser fails to annotate it is difficult for users to find out
    what went wrong.
    
    Add some errors for objdump failures that are displayed in the UI.
    
    Note it would be even better to handle these errors smarter, like
    falling back to the binary when the debug info is somehow corrupted. But
    for now just giving a better error is an improvement.
    
    Committer note:
    
    This works for --stdio, where errors just scroll by the screen:
    
      # perf annotate --stdio intel_idle
      Failure running objdump  --start-address=0xffffffff81418290 --stop-address=0xffffffff814183ae -l -d --no-show-raw -S -C /root/.debug/.build-id/28/2777c262e6b3c0451375163c9a81c893218ab1 2>/dev/null|grep -v /root/.debug/.build-id/28/2777c262e6b3c0451375163c9a81c893218ab1|expand
       Percent |      Source code & Disassembly of vmlinux for cycles:pp
      ------------------------------------------------------------------
    
    And with that one can use that command line to try to find out more about what
    happened instead of getting a blank screen, an improvement.
    
    We need tho to improve this further to get it to work with other UIs, like
    --tui and --gtk, where it continues showing a blank screen, no messages, as
    the pr_err() used is enough just for --stdio.
    Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
    Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: http://lkml.kernel.org/r/1446779167-18949-1-git-send-email-andi@firstfloor.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    62ec9b3f
annotate.c 38.8 KB