• Ard Biesheuvel's avatar
    crypto: arm/crct10dif - revert to C code for short inputs · 62fecf29
    Ard Biesheuvel authored
    The SIMD routine ported from x86 used to have a special code path
    for inputs < 16 bytes, which got lost somewhere along the way.
    Instead, the current glue code aligns the input pointer to permit
    the NEON routine to use special versions of the vld1 instructions
    that assume 16 byte alignment, but this could result in inputs of
    less than 16 bytes to be passed in. This not only fails the new
    extended tests that Eric has implemented, it also results in the
    code reading past the end of the input, which could potentially
    result in crashes when dealing with less than 16 bytes of input
    at the end of a page which is followed by an unmapped page.
    
    So update the glue code to only invoke the NEON routine if the
    input is at least 16 bytes.
    Reported-by: default avatarEric Biggers <ebiggers@kernel.org>
    Reviewed-by: default avatarEric Biggers <ebiggers@kernel.org>
    Fixes: 1d481f1c ("crypto: arm/crct10dif - port x86 SSE implementation to ARM")
    Cc: <stable@vger.kernel.org> # v4.10+
    Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    62fecf29
crct10dif-ce-glue.c 2.06 KB