• Sean Wang's avatar
    Bluetooth: btmtksdio: fix uninitialized symbol errors in btmtksdio_rx_packet · 637c8e90
    Sean Wang authored
    Fixed all the below warnings. They would probably cause the following
    error handling path would use the uninitialized value and then produce
    unexpected behavior.
    
    drivers/bluetooth/btmtksdio.c:470:2: warning: ‘old_len’ may be used
    uninitialized in this function [-Wmaybe-uninitialized]
      print_hex_dump(KERN_ERR, "err sdio rx: ", DUMP_PREFIX_NONE, 4, 1,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              old_data, old_len, true);
              ~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/bluetooth/btmtksdio.c:376:15: note: ‘old_len’ was declared here
      unsigned int old_len;
                   ^~~~~~~
    drivers/bluetooth/btmtksdio.c:470:2: warning: ‘old_data’ may be used
    uninitialized in this function [-Wmaybe-uninitialized]
      print_hex_dump(KERN_ERR, "err sdio rx: ", DUMP_PREFIX_NONE, 4, 1,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              old_data, old_len, true);
              ~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/bluetooth/btmtksdio.c:375:17: note: ‘old_data’ was declared here
      unsigned char *old_data;
                     ^~~~~~~~
    
    v2: Remove old_len and old_data because the error path for sdio_readsb also
        seems wrong. And change the prefix from "mediatek" to "btmtksdio".
    
    Fixes: d74eef2834b5 ("Bluetooth: mediatek: add support for MediaTek MT7663S and MT7668S SDIO devices")
    Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Reported-by: default avatarMarcel Holtmann <marcel@holtmann.org>
    Signed-off-by: default avatarSean Wang <sean.wang@mediatek.com>
    Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
    637c8e90
btmtksdio.c 21.4 KB