• Bjorn Andersson's avatar
    cpufreq: qcom-cpufreq-hw: Revert adding cpufreq qos · e2b47e58
    Bjorn Andersson authored
    The OSM/EPSS hardware controls the frequency of each CPU cluster based
    on requests from the OS and various throttling events in the system.
    While throttling is in effect the related dcvs interrupt will be kept
    high. The purpose of the code handling this interrupt is to
    continuously report the thermal pressure based on the throttled
    frequency.
    
    The reasoning for adding QoS control to this mechanism is not entirely
    clear, but the introduction of commit 'c4c0efb0 ("cpufreq:
    qcom-cpufreq-hw: Add cpufreq qos for LMh")' causes the
    scaling_max_frequncy to be set to the throttled frequency. On the next
    iteration of polling, the throttled frequency is above or equal to the
    newly requested frequency, so the polling is stopped.
    
    With cpufreq limiting the max frequency, the hardware no longer report a
    throttling state and no further updates to thermal pressure or qos
    state are made.
    
    The result of this is that scaling_max_frequency can only go down, and
    the system becomes slower and slower every time a thermal throttling
    event is reported by the hardware.
    
    Even if the logic could be improved, there is no reason for software to
    limit the max freqency in response to the hardware limiting the max
    frequency. At best software will follow the reported hardware state, but
    typically it will cause slower backoff of the throttling.
    
    This reverts commit c4c0efb0.
    
    Fixes: c4c0efb0 ("cpufreq: qcom-cpufreq-hw: Add cpufreq qos for LMh")
    Reported-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Signed-off-by: default avatarBjorn Andersson <quic_bjorande@quicinc.com>
    Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
    Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
    e2b47e58
qcom-cpufreq-hw.c 19.3 KB