• Ido Yariv's avatar
    wlcore: Fix sdio out-of-sync power state · 645865fc
    Ido Yariv authored
    wl12xx_sdio_power_off() manually powers down the card regardless of the
    runtime pm state. If wl12xx_sdio_power_on() is called before the card
    was suspended by runtime PM, it will not power up the card.
    
    As part of the HW detection, the chip's power is toggled. Since this
    happens in the context of probing sdio, the power reference counter will
    be higher than zero. As a result, when wl12xx_sdio_power_off() is
    called, the chip will be powered down while still having a positive
    power reference counter. If the interface is quickly activated, the
    driver might try to transfer data to a powered off chip.
    
    Fix this by ensuring that wl12xx_sdio_power_on() explicitly powers on
    the chip in case runtime pm claims the chip is already powered on. To
    avoid cases in which it is not possible to determine if the chip was
    really powered on (card's power reference counter is positive), operate
    on the mmc_card instead of the function.
    
    Also verify that the chip is indeed powered on before powering off, to
    avoid wrong reference counter values in error cases.
    Signed-off-by: default avatarIdo Yariv <ido@wizery.com>
    Signed-off-by: default avatarLuciano Coelho <coelho@ti.com>
    645865fc
sdio.c 10.1 KB