• Masahiro Yamada's avatar
    kbuild: remove unneeded -O option to dtc · 64bfc994
    Masahiro Yamada authored
    This piece of code converts the target suffix to the dtc -O option:
    
        *.dtb      ->  -O dtb
        *.dt.yaml  ->  -O yaml
    
    Commit ce88c9c7 ("kbuild: Add support to build overlays (%.dtbo)")
    added the third case:
    
        *.dtbo     ->  -O dtbo
    
    This works thanks to commit 163f0469bf2e ("dtc: Allow overlays to have
    .dtbo extension") in the upstream DTC, which has already been pulled in
    the kernel.
    
    However, I think it is a bit odd because "dtbo" is not a format name.
    At least, it does not show up in the help message of dtc.
    
    $ scripts/dtc/dtc --help
      [ snip ]
      -O, --out-format <arg>
            Output formats are:
                    dts - device tree source text
                    dtb - device tree blob
                    yaml - device tree encoded as YAML
                    asm - assembler source
    
    So, I am not a big fan of the second hunk of that change:
    
            } else if (streq(outform, "dtbo")) {
                    dt_to_blob(outf, dti, outversion);
    
    Anyway, we did not need to do this in Makefile in the first place.
    
    guess_type_by_name() had already understood ".yaml" before commit
    4f0e3a57 ("kbuild: Add support for DT binding schema checks"),
    and now does ".dtbo" as well.
    
    Makefile does not need to duplicate the same logic. Let's leave it
    to dtc.
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
    Acked-by: default avatarRob Herring <robh@kernel.org>
    64bfc994
Makefile.lib 17.2 KB