• Paul Fertser's avatar
    plat-mxc: iomux-v3.h: implicitly enable pull-up/down when that's desired · 6571534b
    Paul Fertser authored
    To configure pads during the initialisation a set of special constants
    is used, e.g.
    #define MX25_PAD_FEC_MDIO__FEC_MDIO IOMUX_PAD(0x3c4, 0x1cc, 0x10, 0, 0, PAD_CTL_HYS | PAD_CTL_PUS_22K_UP)
    
    The problem is that no pull-up/down is getting activated unless both
    PAD_CTL_PUE (pull-up enable) and PAD_CTL_PKE (pull/keeper module
    enable) set. This is clearly stated in the i.MX25 datasheet and is
    confirmed by the measurements on hardware. This leads to some rather
    hard to understand bugs such as misdetecting an absent ethernet PHY (a
    real bug i had), unstable data transfer etc. This might affect mx25,
    mx35, mx50, mx51 and mx53 SoCs.
    
    It's reasonable to expect that if the pullup value is specified, the
    intention was to have it actually active, so we implicitly add the
    needed bits.
    
    Cc: stable@kernel.org
    Signed-off-by: default avatarPaul Fertser <fercerpav@gmail.com>
    Signed-off-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
    6571534b
iomux-v3.h 4.58 KB