• Artem Bityutskiy's avatar
    mtd: merge mtdchar module with mtdcore · 660685d9
    Artem Bityutskiy authored
    The MTD subsystem has historically tried to be as configurable as possible. The
    side-effect of this is that its configuration menu is rather large, and we are
    gradually shrinking it. For example, we recently merged partitions support with
    the mtdcore.
    
    This patch does the next step - it merges the mtdchar module to mtdcore. And in
    this case this is not only about eliminating too fine-grained separation and
    simplifying the configuration menu. This is also about eliminating seemingly
    useless kernel module.
    
    Indeed, mtdchar is a module that allows user-space making use of MTD devices
    via /dev/mtd* character devices. If users do not enable it, they simply cannot
    use MTD devices at all. They cannot read or write the flash contents. Is it a
    sane and useful setup? I believe not. And everyone just enables mtdchar.
    
    Having mtdchar separate is also a little bit harmful. People sometimes miss the
    fact that they need to enable an additional configuration option to have
    user-space MTD interfaces, and then they wonder why on earth the kernel does
    not allow using the flash? They spend time asking around.
    
    Thus, let's just get rid of this module and make it part of mtd core.
    
    Note, mtdchar had additional configuration option to enable OTP interfaces,
    which are present on some flashes. I removed that option as well - it saves a
    really tiny amount space.
    
    [dwmw2: Strictly speaking, you can mount file systems on MTD devices just
            fine without the mtdchar (or mtdblock) devices; you just can't do
            other manipulations directly on the underlying device. But still I
            agree that it makes sense to make this unconditional. And Yay! we
            get to kill off an instance of checking CONFIG_foo_MODULE, which is
            an abomination that should never happen.]
    Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
    Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
    660685d9
mtdchar.c 28 KB