• Guoqing Jiang's avatar
    raid1: ensure write behind bio has less than BIO_MAX_VECS sectors · 6607cd31
    Guoqing Jiang authored
    We can't split write behind bio with more than BIO_MAX_VECS sectors,
    otherwise the below call trace was triggered because we could allocate
    oversized write behind bio later.
    
    [ 8.097936] bvec_alloc+0x90/0xc0
    [ 8.098934] bio_alloc_bioset+0x1b3/0x260
    [ 8.099959] raid1_make_request+0x9ce/0xc50 [raid1]
    [ 8.100988] ? __bio_clone_fast+0xa8/0xe0
    [ 8.102008] md_handle_request+0x158/0x1d0 [md_mod]
    [ 8.103050] md_submit_bio+0xcd/0x110 [md_mod]
    [ 8.104084] submit_bio_noacct+0x139/0x530
    [ 8.105127] submit_bio+0x78/0x1d0
    [ 8.106163] ext4_io_submit+0x48/0x60 [ext4]
    [ 8.107242] ext4_writepages+0x652/0x1170 [ext4]
    [ 8.108300] ? do_writepages+0x41/0x100
    [ 8.109338] ? __ext4_mark_inode_dirty+0x240/0x240 [ext4]
    [ 8.110406] do_writepages+0x41/0x100
    [ 8.111450] __filemap_fdatawrite_range+0xc5/0x100
    [ 8.112513] file_write_and_wait_range+0x61/0xb0
    [ 8.113564] ext4_sync_file+0x73/0x370 [ext4]
    [ 8.114607] __x64_sys_fsync+0x33/0x60
    [ 8.115635] do_syscall_64+0x33/0x40
    [ 8.116670] entry_SYSCALL_64_after_hwframe+0x44/0xae
    
    Thanks for the comment from Christoph.
    
    [1]. https://bugs.archlinux.org/task/70992
    
    Cc: stable@vger.kernel.org # v5.12+
    Reported-by: default avatarJens Stutte <jens@chianterastutte.eu>
    Tested-by: default avatarJens Stutte <jens@chianterastutte.eu>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarGuoqing Jiang <jiangguoqing@kylinos.cn>
    Signed-off-by: default avatarSong Liu <songliubraving@fb.com>
    6607cd31
raid1.c 93 KB