• Edward Liaw's avatar
    userfaultfd: selftests: infinite loop in faulting_process · 50b0f797
    Edward Liaw authored
    On Android this test is getting stuck in an infinite loop due to
    indeterminate behavior:
    
    The local variables steps and signalled were being reset to 1 and 0
    respectively after every jump back to sigsetjmp by siglongjmp in the
    signal handler.  The test was incrementing them and expecting them to
    retain their incremented values.  The documentation for siglongjmp says:
    
    All accessible objects have values as of the time sigsetjmp() was called,
    except that the values of objects of automatic storage duration which are
    local to the function containing the invocation of the corresponding
    sigsetjmp() which do not have volatile-qualified type and which are
    changed between the sigsetjmp() invocation and siglongjmp() call are
    indeterminate.
    
    Tagging steps and signalled with volatile enabled the test to pass.
    
    Link: https://lkml.kernel.org/r/20220613233321.431282-1-edliaw@google.comSigned-off-by: default avatarEdward Liaw <edliaw@google.com>
    Reviewed-by: default avatarAxel Rasmussen <axelrasmussen@google.com>
    Cc: Shuah Khan <shuah@kernel.org>
    Cc: Peter Xu <peterx@redhat.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    50b0f797
userfaultfd.c 44.6 KB