• Madalin Bucur's avatar
    arm64: dts: ls1043a-rdb: correct RGMII delay mode to rgmii-id · 66d4ef50
    Madalin Bucur authored
    commit 4022d808 upstream.
    
    The correct setting for the RGMII ports on LS1043ARDB is to
    enable delay on both Rx and Tx so the interface mode used must
    be PHY_INTERFACE_MODE_RGMII_ID.
    
    Since commit 1b3047b5 ("net: phy: realtek: add support for
    configuring the RX delay on RTL8211F") the Realtek 8211F PHY driver
    has control over the RGMII RX delay and it is disabling it for
    RGMII_TXID. The LS1043ARDB uses two such PHYs in RGMII_ID mode but
    in the device tree the mode was described as "rgmii_txid".
    This issue was not apparent at the time as the PHY driver took the
    same action for RGMII_TXID and RGMII_ID back then but it became
    visible (RX no longer working) after the above patch.
    
    Changing the phy-connection-type to "rgmii-id" to address the issue.
    
    Fixes: bf02f2ff ("arm64: dts: add LS1043A DPAA FMan support")
    Signed-off-by: default avatarMadalin Bucur <madalin.bucur@oss.nxp.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    66d4ef50
fsl-ls1043a-rdb.dts 2.87 KB