• Daniel Vetter's avatar
    drm: Fix getconnector connection_mutex locking · 832fd395
    Daniel Vetter authored
    I've fumbled my own idea and enthusiastically wrapped all the
    getconnector code with the connection_mutex. But we only need it to
    chase the connector->encoder link. Even there it's not really needed
    since races with userspace won't matter, but better paranoid and
    consistent about this stuff.
    
    If we grap it everywhere connector probe callbacks can't grab it
    themselves, which means they'll deadlock. i915 does that for the load
    detect pipe. Furthermore i915 needs to do a ww dance since we also
    need to grab the mutex of the load detect crtc.
    
    This is a regression from
    
    commit 6e9f798d
    Author: Daniel Vetter <daniel.vetter@ffwll.ch>
    Date:   Thu May 29 23:54:47 2014 +0200
    
        drm: Split connection_mutex out of mode_config.mutex (v3)
    
    Cc: Rob Clark <robdclark@gmail.com>
    Cc: Dave Airlie <airlied@redhat.com>
    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Reported-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
    Reviewed-by: default avatarRob Clark <robdclark@gmail.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    832fd395
drm_crtc.c 126 KB