• Herbert Xu's avatar
    e1000: Do not truncate TSO TCP header with 82544 workaround · 683a2aa3
    Herbert Xu authored
    The e1000 driver has a workaround for 82544 on PCI-X where if the
    terminating byte of a buffer is at addresses 0-3 mod 8, then 4 bytes
    are shaved off it and defered to a new segment.  This is due to an
    erratum that could otherwise cause TX hangs.
    
    Unfortunately this breaks TSO because it may cause the TCP header to
    be split over two segments which itself causes TX hangs.  The solution
    is to pull 4 bytes of data up from the next segment rather than pushing
    4 bytes off.  This ensures the TCP header remains in one piece and
    works around the PCI-X hang.
    
    This patch is based on one from Jesse Brandeburg.
    
    This bug has been trigered by both CONFIG_DEBUG_SLAB as well as Xen.
    
    Note that the only reason we don't see this normally is because the
    TCP stack starts writing from the end, i.e., it writes the TCP header
    first then slaps on the IP header, etc.  So the end of the TCP header
    (skb->tail - 1 here) is always aligned correctly.
    
    Had we made the start of the IP header (e.g., IPv6) 8-byte aligned
    instead, this would happen for normal TCP traffic as well.
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    Acked-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    --
    Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
    683a2aa3
e1000_main.c 154 KB