• Cory Maccarrone's avatar
    omap: remove BUG_ON for disabled interrupts · 683eb947
    Cory Maccarrone authored
    Remove a BUG_ON for when interrupts are disabled during an MMC request.
    
    During boot, interrupts can be disabled when a request is made, causing
    this bug to be triggered.  In reality, there's no reason this should halt
    the kernel, as the driver has proved reliable in spite of disabled
    interrupts, and additionally, there's nothing in this code that would
    require interrupts to be enabled.
    
    The only setup I've managed to make it trigger on is on the HTC Herald
    during bootup when the driver is built into the kernel (mostly because
    that's all I have).  I believe it's related to the fact that on bootup I
    get many timeout errors on "CMD5" while initializing the card.  Each CMD5
    timeout triggers that bug (I changed it to a WARN_ON to get it to boot in)
    due to the fact that part of the timeout code involves sending the request
    again.  With interrupts turned off, that BUG would be triggered.
    Signed-off-by: default avatarCory Maccarrone <darkstar6262@gmail.com>
    Acked-by: default avatarTony Lindgren <tony@atomide.com>
    Cc: <linux-mmc@vger.kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    683eb947
omap.c 38.8 KB