-
Ard Biesheuvel authored
Commit 41918ec8 ("ARM: ftrace: enable the graph tracer with the EABI unwinder") removed the dummy version of return_address() that was provided for the CONFIG_ARM_UNWIND=y case, on the assumption that the removal of the kernel_text_address() call from unwind_frame() in the preceding patch made it safe to do so. However, this turns out not to be the case: Corentin reports warnings about suspicious RCU usage and other strange behavior that seems to originate in the stack unwinding that occurs in return_address(). Given that the function graph tracer (which is what these changes were enabling for CONFIG_ARM_UNWIND=y builds) does not appear to care about this distinction, let's revert return_address() to the old state. Cc: Corentin Labbe <clabbe.montjoie@gmail.com> Fixes: 41918ec8 ("ARM: ftrace: enable the graph tracer with the EABI unwinder") Signed-off-by:
Ard Biesheuvel <ardb@kernel.org> Reported-by:
Corentin Labbe <clabbe.montjoie@gmail.com> Tested-by:
Corentin Labbe <clabbe.montjoie@gmail.com> Signed-off-by:
Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
6845d64d