• Alan Previn's avatar
    drm/i915/pxp: limit drm-errors or warning on firmware API failures · 69e6dd14
    Alan Previn authored
    MESA driver is creating protected context on every driver handle
    creation to query caps bits for app. So when running CI tests,
    they are observing hundreds of drm_errors when enabling PXP
    in .config but using SOC fusing or BIOS configuration that cannot
    support PXP sessions.
    
    The fixes tag referenced below was to resolve a related issue
    where we wanted to silence error messages, but that case was due
    to outdated IFWI (firmware) that definitely needed an upgrade and
    was, at that point, considered a one-off case as opposed to today's
    realization that default CI was enabling PXP in kernel config for
    all testing.
    
    So with this patch, let's strike a balance between issues that is
    critical but are root-caused from HW/platform gaps (louder drm-warn
    but just ONCE) vs other cases where it could also come from session
    state machine (which cannot be a WARN_ONCE since it can be triggered
    due to runtime operation events).
    
    Let's use helpers for these so as more functions are added in future
    features / HW (or as FW designers continue to bless upstreaming of
    the error codes and meanings), we only need to update the helpers.
    
    NOTE: Don't completely remove FW errors (via drm_debug) or else cusomer
    apps that really needs to know that content protection failed won't
    be aware of it.
    
    v2: - Add fixes tag (Trvtko)
    v3: - Break multi-line drm_dbg strings into separate drm_dbg (Daniele)
        - Fix couple of typecasting nits (Daniele)
    v4: - Unsuccessful PXP FW cmd due to platform configuration shouldn't
          use drm_WARN_once (Tvrtko), Switched to use drm_info_once.
    v5: - Added "reported-and-tested" by Eero.
    Reported-and-tested-by: default avatarEero Tamminen <eero.t.tamminen@intel.com>
    Fixes: b762787b ("drm/i915/pxp: Use drm_dbg if arb session failed due to fw version")
    Signed-off-by: default avatarAlan Previn <alan.previn.teres.alexis@intel.com>
    Reviewed-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
    Signed-off-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20230323184156.4140659-1-alan.previn.teres.alexis@intel.com
    69e6dd14
intel_pxp_tee.c 10.7 KB