• Quentin Schulz's avatar
    net: phy: mscc: migrate to phy_select/restore_page functions · 6a0bfbbe
    Quentin Schulz authored
    The Microsemi PHYs have multiple banks of registers (called pages).
    Registers can only be accessed from one page, if we need a register from
    another page, we need to switch the page and the registers of all other
    pages are not accessible anymore.
    
    Basically, to read register 5 from page 0, 1, 2, etc., you do the same
    phy_read(phydev, 5); but you need to set the desired page beforehand.
    
    In order to guarantee that two concurrent functions do not change the
    page, we need to do some locking per page. This can be achieved with the
    use of phy_select_page and phy_restore_page functions but phy_write/read
    calls in-between those two functions shall be replaced by their
    lock-free alternative __phy_write/read.
    
    Let's migrate this driver to those functions.
    Suggested-by: default avatarAndrew Lunn <andrew@lunn.ch>
    Signed-off-by: default avatarQuentin Schulz <quentin.schulz@bootlin.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    6a0bfbbe
mscc.c 19.6 KB