• Nuno Sá's avatar
    iio: health: max30102: do not use internal iio_dev lock · 6b701cda
    Nuno Sá authored
    The pattern used in this device does not quite fit in the
    iio_device_claim_direct_mode() typical usage. In this case, we want to
    know if we are in buffered mode or not to know if the device is powered
    (buffer mode) or not. And depending on that max30102_get_temp() will
    power on the device if needed. Hence, in order to keep the same
    functionality, we try to:
    
    1. Claim Buffered mode;
    2: If 1) succeeds call max30102_get_temp() without powering on the
       device;
    3: Release Buffered mode;
    4: If 1) fails, Claim Direct mode;
    5: If 4) succeeds call max30102_get_temp() with powering on the device;
    6: Release Direct mode;
    7: If 4) fails, goto to 1) and try again.
    
    This dance between buffered and direct mode is not particularly pretty
    (as well as the loop introduced by the goto statement) but it does allow
    us to get rid of the mlock usage while keeping the same behavior.
    Signed-off-by: default avatarNuno Sá <nuno.sa@analog.com>
    Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
    Link: https://lore.kernel.org/r/20221012151620.1725215-4-nuno.sa@analog.comSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
    6b701cda
max30102.c 16 KB