Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
You need to sign in or sign up before continuing.
  • linux
  • scripts
  • checkpatch.pl
Find file BlameHistoryPermalink
  • Jakub Kicinski's avatar
    checkpatch: warn about uses of ENOTSUPP · 6b9ea5ff
    Jakub Kicinski authored May 11, 2020
    ENOTSUPP often feels like the right error code to use, but it's
    in fact not a standard Unix error. E.g.:
    
    $ python
    >>> import errno
    >>> errno.errorcode[errno.ENOTSUPP]
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
    AttributeError: module 'errno' has no attribute 'ENOTSUPP'
    
    There were numerous commits converting the uses back to EOPNOTSUPP
    but in some cases we are stuck with the high error code for backward
    compatibility reasons.
    
    Let's try prevent more ENOTSUPPs from getting into the kernel.
    
    Recent example:
    https://lore.kernel.org/netdev/20200510182252.GA411829@lunn.ch/
    
    v3 (Joe):
     - fix the "not file" condition.
    
    v2 (Joe):
     - add a link to recent discussion,
     - don't match when scanning files, not patches to avoid sudden
       influx of conversion patches.
    https://lore.kernel.org/netdev/20200511165319.2251678-1-kuba@kernel.org/
    
    v1:
    https://lore.kernel.org/netdev/20200510185148.2230767-1-kuba@kernel.org/
    
    
    
    Suggested-by: default avatarAndrew Lunn <andrew@lunn.ch>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    Acked-by: default avatarJoe Perches <joe@perches.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    6b9ea5ff
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7