• Andrea Merello's avatar
    rtl8180: don't use weird trick to access "far" registers · 6cea5f21
    Andrea Merello authored
    In rtl8180/rtl8185/rtl8187se the register space is represented
    using packed structure type. Register are thus accessed using a
    pointer of this type.
    All registers are packed toghether, and only small gaps are present.
    
    However Rtl8187se has also some "sparse" registers, very far from
    the "main register block".
    
    It could be possible to access them by simply declare huge reserved
    blocks inside the register struct (and this causes NO memory waste).
    However, for various reasons, access to those "far" registers is
    done with special dedicated macros, without declaring them in the
    register struct.
    
    This is done in an intricate manner, that makes code less readable
    and caused static analisys tool to produce warnings.
    
    This patch keeps the "macro" mechanism, but it changes its
    implementation in a simplier and more straightforward way.
    Signed-off-by: default avatarAndrea Merello <andrea.merello@gmail.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    6cea5f21
rtl818x.h 12.4 KB